Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover titles do not translate #1100

Open
IgslJaneFeng opened this issue Jan 2, 2025 · 2 comments
Open

Hover titles do not translate #1100

IgslJaneFeng opened this issue Jan 2, 2025 · 2 comments
Labels
backlog Queued in backlog bug Something isn't working i18n pr welcome We rely on a community contribution to improve this.

Comments

@IgslJaneFeng
Copy link

IgslJaneFeng commented Jan 2, 2025

Describe the Bug

The translated file has translated the text content, but the page has not been successfully replaced with the translated text

Steps to Reproduce

  1. The text content that appears in hover, such as adding "Toggle section" to the translated text
  2. Change language - zh-CN
  3. "Toggle section" Not displayed as Chinese on the page

Expected Behavior

Hover text content can be successfully translated by translating additional modules

Environment

  • Host (Browser/Node version), if applicable: Chrome 131
  • OS: Windows 11
  • Library version: "bpmn-js-properties-panel": "^5.30.0"
    image
    image
    image
@IgslJaneFeng IgslJaneFeng added the bug Something isn't working label Jan 2, 2025
@nikku nikku added the i18n label Jan 2, 2025
@nikku
Copy link
Member

nikku commented Jan 2, 2025

The relevant paths that define such titles are these:

It looks like translation capabilities for the keys you flagged are already available, cf.

I suggest you to check the translation file; it may not be up to date, i.e. may not contain entries for some strings.

We're open to contributions that make more parts of the code base translateable (i.e. https://github.com/bpmn-io/properties-panel/blob/2b167d95675db9208da8c4c8f594860892fc3517/src/components/entries/List.js#L104).

@nikku nikku changed the title Translation: Unable to successfully translate hover title attribute text content ('Toggle section','Create new list item')/ hover 'Create' text Hover titles do not translate Jan 2, 2025
@nikku nikku added backlog Queued in backlog pr welcome We rely on a community contribution to improve this. labels Jan 2, 2025
@Vitya23
Copy link

Vitya23 commented Jan 20, 2025

Exactly the same problem on the latest version of the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working i18n pr welcome We rely on a community contribution to improve this.
Projects
None yet
Development

No branches or pull requests

3 participants