New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expt must pop stack #1

Open

dcurrie opened this issue Aug 25, 2020 · 1 comment

dcurrie commented Aug 25, 2020

The expt function does not manage the stack correctly. This fixes it for me:

static void primop_expt(long arg) {
	double tmp = the_double(1,sp[0]);
	tmp = pow(tmp,the_double(2,sp[1]));
	*++sp = make_flonum(tmp);
}

Note the addition of ++.

The text was updated successfully, but these errors were encountered:

Author

dcurrie commented Aug 25, 2020

Test case at prompt:

(- (expt 2 29) 1)

Gives 536870883 but should be 536870911.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment