Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save wall points? #93

Open
johnomotani opened this issue Mar 18, 2021 · 3 comments
Open

Save wall points? #93

johnomotani opened this issue Mar 18, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@johnomotani
Copy link
Collaborator

At least when creating a grid from a geqdsk file, the data is saved already because we save the geqdsk file, but it might be nice to save the wall points in a more accessible form in the grid file - can be useful for analysis and post-processing.

@johnomotani johnomotani added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Mar 18, 2021
@ZedThree
Copy link
Member

I had a very brief stab at creating a spec for a file format that might be useful here: https://github.com/ZedThree/OpenPlasmaEquilibrium

This basically evolved from the FreeGS file format, so almost certainly needs more things to be useful for Hypnotoad

@johnomotani
Copy link
Collaborator Author

Interesting! At a first glance, it seems like it might be possible to make hypnotoad grid files valid OPEQS files by storing all the equilibrium information in appropriate groups/variables. That seems like in could be a nice thing to do because it's a sensible format to store equilibrium data which it'd be nice to access again from a grid file, and the information's probably already available in hypnotoad. Might need to stop using boututils.DataFile and use netcdf4.Dataset directly, but that should be a relatively minor change. If we add an option for generating grids from vacuum fields of coils as suggested here #90 (comment), OPEQS format would be a nice way to save the configuration in that case too.

@bendudson
Copy link
Contributor

Using netcdf4.Dataset directly is probably not such a bad idea now: boututils.DataFile was developed when there were many (3?) different NetCDF libraries for python, all slightly incompatible, and installing them was much more painful than it is now. DataFile is quite convenient for simple datasets, but at least some of the reason for having a wrapper has gone now.

@johnomotani johnomotani removed the good first issue Good for newcomers label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants