Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neutral_f_pn flag default behaviour #13

Open
mikekryjak opened this issue May 26, 2022 · 0 comments
Open

neutral_f_pn flag default behaviour #13

mikekryjak opened this issue May 26, 2022 · 0 comments

Comments

@mikekryjak
Copy link
Collaborator

If not solving neutral momentum if the neutral_f_pn flag is set to True, SD1D will overwrite the plasma momentum sink term F with the gradient of the neutral pressure, likely to maintain a force balance in the case. It is set to True by default.

This feature can be useful because it ensures that default behaviour leads to momentum conservation. However, this behaviour is not described in the manual, the name of the flag is not clear and the individual force sinks are still calculated and outputted (Fiz, Frec, Fcx, Fel) even though they will not be used for F, which can be misleading.

I suggest:

  • Renaming the flag to force_f_balance
  • Including a description of its behaviour in the manual
  • Setting Fiz, Frec, Fcx and Fel to 0 if the flag is set to True
  • Maintain default behaviour as True
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant