Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

SocketRocket Podspec out of date #123

Open
jleach opened this issue Jan 21, 2015 · 1 comment
Open

SocketRocket Podspec out of date #123

jleach opened this issue Jan 21, 2015 · 1 comment

Comments

@jleach
Copy link

jleach commented Jan 21, 2015

It looks like the commit the SocketRocket Podspec references is quite stale:

commit 82c9f8938f8b9b7aa578866cb7ce56bc11e52ced
Merge: 4313297 facb4d9
Author: Mike Lewis <[email protected]>
Date:   Thu Jun 14 00:29:55 2012 -0700

    Merge pull request #28 from MSch/patch-1

    Only require CFNetwork on iOS so that podspec works on Lion

This reference has a bug in that the delegate in WebSocket.h is using assign rater than weak:

@property (nonatomic, assign) id <SRWebSocketDelegate> delegate;

This can cause EXC_BAD_ACCESS exception of the delegate is freed but called. I can reproduce this by calling login multiple times quickly while disconnected from the server. I've created an issue agains SocketRocket asking for an update: facebookincubator/SocketRocket#216

_I think SocketRocket is poorly maintained. Might be worth considering a different library._

@mikey0000
Copy link
Collaborator

Indeed you are right it isn't getting as much love as it needs, I've got a version of ObjectiveDDP using SocketKit but that library is also quite new and has its own share of issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants