Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry to axios when the api did not respond (ENOTFOUND, ETIMEDOUT, etc) to prevent network glitches #651

Open
leopucci opened this issue Aug 31, 2021 · 2 comments

Comments

@leopucci
Copy link

leopucci commented Aug 31, 2021

Hi. Thanks for this module. It help´s me a lot!

Sometimes api´s freezes for one second or so. Or a minor network problem.
Why not retry on no response errors?
There is a package for axios. https://www.npmjs.com/package/retry-axios

There is a way to pin point the exact codes to retry,
you can retry only on no response,
or you can retry on specific http response codes.

i don´t know the proper response codes from the api that this could be useful
But I do think that 2 retries if the api does not respond is a good thing that can prevent minor network problems and guarantee more sucess on the delivering.

 // Retry 3 times on requests that return a response (500, etc) before giving up.  Defaults to 3.
    retry: 3,

    // Retry twice on errors that don't return a response (ENOTFOUND, ETIMEDOUT, etc).
    noResponseRetries: 2,

    // Milliseconds to delay at first.  Defaults to 100. Only considered when backoffType is 'static'
    retryDelay: 100,

    // HTTP methods to automatically retry.  Defaults to:
    // ['GET', 'HEAD', 'OPTIONS', 'DELETE', 'PUT']
    httpMethodsToRetry: ['GET', 'HEAD', 'OPTIONS', 'DELETE', 'PUT'],

    // The response status codes to retry.  Supports a double
    // array with a list of ranges.  Defaults to:
    // [[100, 199], [429, 429], [500, 599]]
    statusCodesToRetry: [[100, 199], [429, 429], [500, 599]],
@leopucci leopucci changed the title add retry to axios when the api did not respond Add retry to axios when the api did not respond Aug 31, 2021
@leopucci leopucci changed the title Add retry to axios when the api did not respond Add retry to axios when the api did not respond (ENOTFOUND, ETIMEDOUT, etc) Aug 31, 2021
@leopucci leopucci changed the title Add retry to axios when the api did not respond (ENOTFOUND, ETIMEDOUT, etc) Add retry to axios when the api did not respond (ENOTFOUND, ETIMEDOUT, etc) to prevent network glitches Aug 31, 2021
@chentsulin
Copy link
Member

chentsulin commented Aug 31, 2021

Feel free to add your interceptors to the underlying axios instance: client.axios.

For example:

const client = new MessengerClient({
  accessToken: ACCESS_TOKEN,
  appId: APP_ID,
  appSecret: APP_SECRET,
  version: '6.0',
});

client.axios.defaults.raxConfig = {
  instance: client.axios
};
const interceptorId = rax.attach(client.axios);

@leopucci
Copy link
Author

Nice! I din´t get it how could I attach it. I just did it. 👍
Thanks @chentsulin 🥇
I will let the issue open to you guys discuss if this is a good fit to add globally to the code or just to let user attach by himself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants