Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrying incomplete downloads with urllib3 2.x #301

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

apmorton
Copy link
Contributor

@apmorton apmorton commented Mar 6, 2024

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (dad5c83) to head (d57aff5).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #301   +/-   ##
========================================
  Coverage    82.94%   82.94%           
========================================
  Files           16       16           
  Lines         2814     2814           
========================================
  Hits          2334     2334           
  Misses         480      480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @apmorton! Yep, this definitely looks like a missed behavior change when 2.x support was added. We'd be happy to merge this. I made a minor change to fix a linting error, but otherwise this looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants