Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onlymissingartwork not really skipping existing files #137

Open
grgohr opened this issue Dec 16, 2022 · 2 comments
Open

onlymissingartwork not really skipping existing files #137

grgohr opened this issue Dec 16, 2022 · 2 comments

Comments

@grgohr
Copy link

grgohr commented Dec 16, 2022

the -onlymissingartwork flag seems to still manage/modify existing files (log shows "xxx found from backup" + date files are modified "for nothing" in the /grid and /grid/originals folders although previously there) instead of actually skipping existing files and looking for a few missing files only.

i am running with -nonsteamonly -onlymissingartwork -steamgriddb id when 99% of non steam files are ok, but the program still spends most of its time looking for and modifying existing files in "backup", often leading to an out of memory error (another open issue) and not looking for the missing files which was the initial purpose
image

@Lucki
Copy link
Contributor

Lucki commented Dec 22, 2022

Append --onlymissingartwork to only download artworks missing on the official servers.

This option only makes sure to fetch artworks where steam won't provide any and not override otherwise. This makes sure older games where no vertical artwork exists (and steam blurs the horizontal artwork awkwardly in) will get proper artwork and official artwork won't be overridden at the same time.

The other option --nonsteamonly actually renders --onlymissingartwork useless because there aren't any steam games to begin with while the round trips are still in place. You probably want --skipsteam.

@grgohr
Copy link
Author

grgohr commented Dec 22, 2022

thank you for the explanations, I better understand the options now.

Still is there any option not to re-write files when already present in the /grid folder ?
I feel that files are modified/overwritten even if previously there/the same ?

I guess this is related to the overlays which are probaly recalculated each time (makes senses) but I removed its folder on purpose (maye a --skipoverlay option might be an answer ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants