From bf0104807e1a9a511787da8cd7138967cbb7fa55 Mon Sep 17 00:00:00 2001
From: Alessandro Amici <a.amici@bopen.eu>
Date: Wed, 9 Mar 2022 09:21:34 +0100
Subject: [PATCH] Try testing python 3.8

---
 .github/workflows/on-push.yml | 132 +++++++++++++++++-----------------
 setup.cfg                     |   3 +-
 2 files changed, 67 insertions(+), 68 deletions(-)

diff --git a/.github/workflows/on-push.yml b/.github/workflows/on-push.yml
index 9fe2c3a..93d562d 100644
--- a/.github/workflows/on-push.yml
+++ b/.github/workflows/on-push.yml
@@ -5,7 +5,7 @@ on:
     branches:
       - main
     tags:
-      - '*'
+      - "*"
   pull_request:
     branches:
       - main
@@ -18,33 +18,32 @@ jobs:
         shell: bash -l {0}
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Cache conda
-      uses: actions/cache@v2
-      with:
-        path: ~/conda_pkgs_dir
-        key:
-          ubuntu-latest-3.9
-    - uses: conda-incubator/setup-miniconda@v2
-      with:
-        channels: default, conda-forge
-        channel-priority: strict
-        mamba-version: "*"
-        activate-environment: ubuntu-latest-3.9
-        auto-update-conda: false
-        python-version: 3.9
-        use-only-tar-bz2: true
-    - name: Install dependencies
-      run: |
-        make conda-env-update CONDA=mamba ENVIRONMENT=ubuntu-latest-3.9
-    - name: Install package
-      run: |
-        python -m pip install --no-deps -e .
-    - name: Run tests
-      run: |
-        make test COV_REPORT=xml
-    - name: Upload code coverage to Codecov
-      uses: codecov/codecov-action@v1
+      - uses: actions/checkout@v2
+      - name: Cache conda
+        uses: actions/cache@v2
+        with:
+          path: ~/conda_pkgs_dir
+          key: ubuntu-latest-3.8
+      - uses: conda-incubator/setup-miniconda@v2
+        with:
+          channels: default, conda-forge
+          channel-priority: strict
+          mamba-version: "*"
+          activate-environment: ubuntu-latest-3.8
+          auto-update-conda: false
+          python-version: 3.8
+          use-only-tar-bz2: true
+      - name: Install dependencies
+        run: |
+          make conda-env-update CONDA=mamba ENVIRONMENT=ubuntu-latest-3.8
+      - name: Install package
+        run: |
+          python -m pip install --no-deps -e .
+      - name: Run tests
+        run: |
+          make test COV_REPORT=xml
+      - name: Upload code coverage to Codecov
+        uses: codecov/codecov-action@v1
 
   code-quality:
     runs-on: ubuntu-latest
@@ -53,48 +52,47 @@ jobs:
         shell: bash -l {0}
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Cache conda
-      uses: actions/cache@v2
-      with:
-        path: ~/conda_pkgs_dir
-        key:
-          ubuntu-latest-3.9
-    - uses: conda-incubator/setup-miniconda@v2
-      with:
-        channels: default, conda-forge
-        channel-priority: strict
-        mamba-version: "*"
-        activate-environment: ubuntu-latest-3.9
-        auto-update-conda: false
-        python-version: 3.9
-        use-only-tar-bz2: true
-    - name: Install dependencies
-      run: |
-        make conda-env-update CONDA=mamba ENVIRONMENT=ubuntu-latest-3.9
-    - name: Install package
-      run: |
-        python -m pip install --no-deps -e .
-    - name: Run code quality checks
-      run: |
-        make code-quality
-    - name: Run code style checks
-      run: |
-        make code-style
+      - uses: actions/checkout@v2
+      - name: Cache conda
+        uses: actions/cache@v2
+        with:
+          path: ~/conda_pkgs_dir
+          key: ubuntu-latest-3.8
+      - uses: conda-incubator/setup-miniconda@v2
+        with:
+          channels: default, conda-forge
+          channel-priority: strict
+          mamba-version: "*"
+          activate-environment: ubuntu-latest-3.8
+          auto-update-conda: false
+          python-version: 3.8
+          use-only-tar-bz2: true
+      - name: Install dependencies
+        run: |
+          make conda-env-update CONDA=mamba ENVIRONMENT=ubuntu-latest-3.8
+      - name: Install package
+        run: |
+          python -m pip install --no-deps -e .
+      - name: Run code quality checks
+        run: |
+          make code-quality
+      - name: Run code style checks
+        run: |
+          make code-style
 
   distribution:
     runs-on: ubuntu-latest
     needs: [unit-tests, code-quality]
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Build distributions
-      run: |
-        $CONDA/bin/python -m pip install build
-        $CONDA/bin/python -m build
-    - name: Publish a Python distribution to PyPI
-      if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
-      uses: pypa/gh-action-pypi-publish@release/v1
-      with:
-        user: __token__
-        password: ${{ secrets.PYPI_API_TOKEN }}
\ No newline at end of file
+      - uses: actions/checkout@v2
+      - name: Build distributions
+        run: |
+          $CONDA/bin/python -m pip install build
+          $CONDA/bin/python -m build
+      - name: Publish a Python distribution to PyPI
+        if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags')
+        uses: pypa/gh-action-pypi-publish@release/v1
+        with:
+          user: __token__
+          password: ${{ secrets.PYPI_API_TOKEN }}
diff --git a/setup.cfg b/setup.cfg
index 31ba03f..1db164c 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -11,6 +11,7 @@ classifiers =
     Operating System :: OS Independent
     Programming Language :: Python
     Programming Language :: Python :: 3
+    Programming Language :: Python :: 3.8
     Programming Language :: Python :: 3.9
     Topic :: Scientific/Engineering
 long_description_content_type=text/markdown
@@ -18,7 +19,7 @@ long_description = file: README.md
 
 [options]
 packages = find:
-python_requires = >=3.9
+python_requires = >=3.8
 install_requires =
     attrs
     click