Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asan detects stack-buffer-overflow when using try/catch #92

Open
mgaunard opened this issue Mar 17, 2020 · 3 comments
Open

asan detects stack-buffer-overflow when using try/catch #92

mgaunard opened this issue Mar 17, 2020 · 3 comments

Comments

@mgaunard
Copy link
Contributor

catch_all_gen is holding the "try" sub-expression by reference, which of course is not valid.
Holding them by value and using base_type instead of that_type fixes the bug.

while, do/while and switch also have this bug.
Interestingly 'if' and 'for' do not.

is_actor appears to also not be consistently specialized.

@djowel
Copy link
Collaborator

djowel commented Mar 18, 2020

Will you do a PR for this?

@mgaunard
Copy link
Contributor Author

#94

@djowel
Copy link
Collaborator

djowel commented Mar 22, 2020

#94

Wonderful! Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants