From 67f021ae3db9db6d0e3d3ffa47efd0b6764af82f Mon Sep 17 00:00:00 2001
From: Dirk Stolle <striezel-dev@web.de>
Date: Fri, 5 Jul 2024 00:56:34 +0200
Subject: [PATCH] CI improvements and workarounds (#750)

* ci: add workaround for failing container jobs

Node.js 20 is not supported in older containers like ubuntu:18.04,
but GitHub Actions nowawadays forces the use of Node.js 20, even
if the action itself still specified Node.js 16 as the version to
use. The result is that e.g. `actions/checkout@v3` fails in the
containers, although it should not (because v3 is still specified
Node.js 16).

See <https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/>
for more information on that forced Node.js version. Fortunately,
there still is a workaround to restore the old behaviour, and
that is to set a environment variable to allow older Node.js to
be used in those actions, and that is what this change does.

* ci: switch from macOS 11 to macOS 12

The runner image for macOS 11 has been removed on 2024-06-28. See
<https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/>
for more information on that.

So the easiest fix is probably just to move to the next newest
version of macOS that is still avaiable for GHA.
---
 .github/workflows/ci.yml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f8bddcd1b..492b21d1c 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -11,6 +11,7 @@ on:
 env:
   LIBRARY: gil
   UBSAN_OPTIONS: print_stacktrace=1
+  ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
 
 jobs:
   posix:
@@ -83,7 +84,7 @@ jobs:
             os: ubuntu-20.04
           - toolset: clang
             cxxstd: "14,17"
-            os: macos-11
+            os: macos-12
 
     runs-on: ${{matrix.os}}
     container: ${{matrix.container}}