REQUEST: Optional fees

[stevenroose]

We're interested in running an instance of UbiTok internally for trading between our own ERC20 tokens.

For this, we would like to be able to disable the fee functionality. I think by requesting a fee rate upon construction and skipping all fee-related logic when this is 0 would make sense.

[kieranelby]

Hi Steven,

Thanks for the feature suggestion. Yes, supporting a custom fee (including no-fee) makes sense.

I'm afraid development on UbiTok.io is currently suspended so it's not likely to happen any time soon :( Sadly, while a totally decentralized exchange is cool technically, it's not currently very practical commercially - paying $$ in gas to place an order that never gets filled is not popular.

As a quick workaround, you could probably (I've not tested!) just replace this line:

uint constant feeDivisor = 2000;

with a huge number - e.g.

uint constant feeDivisor = 10 ** 36;

Then the fee would get rounded to zero.

Regards,
Kieran

[stevenroose]

Hi @kieranelby, thanks for the heads-up! Would you know of any alternative project similar to UbiTok?

We've been looking at several, but the few ones that exist all seem discontinued.

[kieranelby]

I'm not sure it's particularly active either, but https://cryptoderivatives.market/ ( https://github.com/bokkypoobah/TokenTrader/wiki ) is one example I know of a fully decentralized exchange. The EtherDelta contract is normally used with an order book server, but I think it can be used directly at the contract level.