Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in Travis #284

Closed
rgaiacs opened this issue Feb 8, 2021 · 5 comments
Closed

Run tests in Travis #284

rgaiacs opened this issue Feb 8, 2021 · 5 comments

Comments

@rgaiacs
Copy link
Collaborator

rgaiacs commented Feb 8, 2021

Can we use Travis CI to run mvn test -P allTests? #283 illustrates that we are not using Travis CI to run the tests.

@alessandrofelder
Copy link
Member

alessandrofelder commented Feb 8, 2021

Think the idea is that we don't run the "slow" (annotated with @Category(org.bonej.wrapperPlugins.SlowWrapperTest.class)) tests on Travis - as they tend to time out from time to time, indicating a bug when there is none. It's documented in the wiki (pt 5.) to check locally with -P allTests when we release the code... although probably good to do this more often than that.

I agree that the current situation is far from ideal wrt these issues. It might be resolved by switching to GitHub actions (who offer machines with better specs and longer time-out limits (although I wouldn't count on this) - we should consider this anyway if the whole of ImageJ switches to GitHub actions, which is a possibility apparently).

So maybe it's worth experimenting with Travis and -P allTests? I don't know.

@mdoube
Copy link
Member

mdoube commented Aug 12, 2021

I wonder if this has something to do with #300 ?

@alessandrofelder
Copy link
Member

In what way do you mean, @mdoube ? Are you suggesting that all wrapperPlugins annotated with @Category(org.bonej.wrapperPlugins.SlowWrapperTest.class) suffer from the same zombie thread business, and are too slow to not time out on Travis for this reason?

@mdoube
Copy link
Member

mdoube commented Aug 13, 2021

More like the zombies slow everything down and cause the whole job to time out. Zombie threads / bad threading model might also be behind the recurring test failure we get with Fractal Dimension #229

@mdoube
Copy link
Member

mdoube commented Jun 16, 2022

Closing, testing and CI has moved to Github Actions

@mdoube mdoube closed this as completed Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants