Skip to content
This repository has been archived by the owner on Nov 18, 2018. It is now read-only.

Production release expectation! #86

Open
baljeet opened this issue Jul 3, 2017 · 10 comments
Open

Production release expectation! #86

baljeet opened this issue Jul 3, 2017 · 10 comments

Comments

@baljeet
Copy link

baljeet commented Jul 3, 2017

Are there any plans to have a production release for re-bulma? This repo looks very promising.

@bokuweb
Copy link
Owner

bokuweb commented Jul 7, 2017

I want to catch up original bulma.css and rethink css in js. 🙏

@dav-is
Copy link

dav-is commented Sep 23, 2017

Update?

@bokuweb
Copy link
Owner

bokuweb commented Sep 24, 2017

Sorry... not yet.

  1. I would like to use react v16, because multiple react element can return in render method. Then We need to adjust each components.

  2. I would like to automate catch up original bulma css with using styled-components (or other).
    But it seems time consuming. I have not started yet....

@dav-is
Copy link

dav-is commented Sep 24, 2017

On the plus side, I hear React 16 is coming sometime next week

@nightwolfz
Copy link
Contributor

Well, it's out now :)

@kresli
Copy link

kresli commented Oct 1, 2017

Thank you for this project!

However I think the whole project need to be updated. I tried to develop on it, but I've got couple errors. Hopefully I will have time to update this with following changes.

  • use create-react-app (including react 16)
  • remove karma (I dont see any test) and replace it by jest and snapshot tests
  • update outdated packages
  • replace class conation by classname package

I just starting new project and I choose bulma for the flexibility, looking forward to start contribute, but really the project need to be updated. Will create pull request.

@bokuweb
Copy link
Owner

bokuweb commented Oct 1, 2017

@kresli Thanks.

use create-react-app (including react 16) 👍
update outdated packages 👍
replace class conation by classname package 👍

remove karma (I dont see any test) and replace it by jest and snapshot tests

But, I would like to use avaron (https://github.com/bokuweb/avaron). Because It is able to use snapshot and taking screenshot (It is useful to do visual regression test.)

@bokuweb
Copy link
Owner

bokuweb commented Oct 1, 2017

And I would like to add flowtype annotation....

@kresli
Copy link

kresli commented Oct 1, 2017

avaron - In your project you are using styleguidist. Isn't that enough?
flowtype - To be honest I tried flowtype and run into more issues then resolved. However, that was time ago so maybe its more stable. I'm big fun of react + typescript and I could easily convert components to typescript if necessary.
Both request could be added later as plugins and because I dont have much experience with any of those, I would skip this in PR and leave it for another one. I already working on it, will see whats we'll get :)

@bokuweb
Copy link
Owner

bokuweb commented Oct 1, 2017

Ok, I'm sure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants