Skip to content
This repository has been archived by the owner on Nov 18, 2018. It is now read-only.

utilize classnames library instead of manually joining classes #60

Open
capaj opened this issue Feb 13, 2017 · 4 comments
Open

utilize classnames library instead of manually joining classes #60

capaj opened this issue Feb 13, 2017 · 4 comments

Comments

@capaj
Copy link
Collaborator

capaj commented Feb 13, 2017

joining often creates unneeded spaces, which results in something like

class="tabs    is-fullwidth"

This could be much better if re-bulma used classnames. The same bug is #50

@bokuweb
Copy link
Owner

bokuweb commented Feb 13, 2017

@capaj thanks. If you want to customize re-bulma, may I invite you to this repogitory as collaborator?

@capaj
Copy link
Collaborator Author

capaj commented Feb 13, 2017

@bokuweb sure. I can't promise I'll have time to fix this soon, but I can at least start on this in a branch.

@gurre
Copy link

gurre commented Nov 30, 2017

Please keep down the number of dependancies at all costs.

@capaj
Copy link
Collaborator Author

capaj commented Nov 30, 2017

@gurre the lib is 50 lines of code and it will probably save around 100 LOC on this project. Well worth it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants