-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add action to generate human pangenome index and filter against it #196
Conversation
Use seqtk to convert to uppercase
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
- Coverage 98.42% 97.93% -0.50%
==========================================
Files 81 150 +69
Lines 4448 9143 +4695
Branches 0 404 +404
==========================================
+ Hits 4378 8954 +4576
- Misses 70 140 +70
- Partials 0 49 +49 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I am waiting for the execution to be completed, here are some comments for some minor changes.
Co-authored-by: Christos Konstantinos Matzoros <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @misialq, everything looks good to me now. Ready to merge!
This PR adds an action allowing to:
filter-reads
action fromq2-quality-control
)If anyone wants to test this before merging, you'll need to install the missing dependencies: gfatools, seqtk and q2-quality-control.
To test, execute the following:
After the first go, you can then try to use the index obtained through that action to test whether things work when an index is provided:
After the second run
new-index.qza
andnewer-index.qza
should be the same artifact.