-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add fetch-eggnog-hmmer-db
action
#173
Conversation
Hi @Sann5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
I ran it and it works with no problems.
See some minor changes and typos below. :)
Co-authored-by: VinzentRisch <[email protected]>
Co-authored-by: VinzentRisch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! :)
I made quite a bit of changes @VinzentRisch since there were changes required in the dependent PR. could you give it a another look before i merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sann5, I think this still needs a bit of work - see below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sann5, thanks for those changes! The error handling is much better now 🥇 See some more comments below.
This PR/issue depends on: |
What's new
fetch-hmmer-db
action #167Blocked by...
Run it locally