Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: wrong description for --i-busco-db in evaluate-busco #214

Closed
VinzentRisch opened this issue Oct 24, 2024 · 3 comments · Fixed by #216
Closed

BUG: wrong description for --i-busco-db in evaluate-busco #214

VinzentRisch opened this issue Oct 24, 2024 · 3 comments · Fixed by #216
Assignees
Labels
bug Something isn't working

Comments

@VinzentRisch
Copy link
Contributor

VinzentRisch commented Oct 24, 2024

Describe the bug
The description for --i-busco-db in evaluate-busco says:
"BUSCO database. If provided BUSCO will run in
offline mode. If not provided a BUSCO database will
be downloaded to a temporary location and then
deleted."

But this is not true, if the db is not provided there is this error:
There was a problem with the command:
(1/1) Missing option '--i-busco-db'.

In the code it also does not look like this functionality was added, so I think the description is just wrong.

To Reproduce
Steps to reproduce the behavior:
qiime moshpit evaluate-busco --i-bins mags.qza --output-dir out

Please complete the following information:

  • OS: macOS
  • QIIME 2 version: 2024.10.0.dev0+28.g10bb850
@VinzentRisch VinzentRisch added the bug Something isn't working label Oct 24, 2024
@VinzentRisch VinzentRisch changed the title BUG: Wronf description for --i-busco-db in evaluate-busco BUG: Wronf description for --i-busco-db in evaluate-busco Oct 24, 2024
@VinzentRisch VinzentRisch changed the title BUG: Wronf description for --i-busco-db in evaluate-busco BUG: Wrong description for --i-busco-db in evaluate-busco Oct 24, 2024
@misialq
Copy link
Contributor

misialq commented Nov 1, 2024

Hey @VinzentRisch, just to clarify: you mean that functionality of downloading the DB if not provided was not added?

@misialq misialq changed the title BUG: Wrong description for --i-busco-db in evaluate-busco BUG: wrong description for --i-busco-db in evaluate-busco Nov 1, 2024
@VinzentRisch
Copy link
Contributor Author

Yes I mean that is not a problem, but then it should be removed from the description.
Should I remove it?

@misialq
Copy link
Contributor

misialq commented Nov 5, 2024

Yeah, that would be nice - otherwise it's a bit confusing... Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants