Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to keep original downloaded silva files and/or different taxonomy files? #48

Open
mikerobeson opened this issue Jun 13, 2020 · 6 comments
Labels
question Further information is requested

Comments

@mikerobeson
Copy link
Collaborator

mikerobeson commented Jun 13, 2020

Should we allow an option to keep the raw imported SILVA files we download?

My thinking is that if users would like to construct classifiers with and without species labels they will not have to go through the download option twice.

Or... given that this is a nice convenience method, we can simply return both taxonomy files, i.e., with and without species labels, and then there'd be no need for the option of writing out the raw files? This would will make constructing the silva dbs much easier for each qiime release.

I suppose we can do it all.. but that might be confusing.

@mikerobeson mikerobeson added the question Further information is requested label Jun 13, 2020
@nbokulich
Copy link
Collaborator

I agree downloading twice is an annoyance...

do we have any methods that could just slice the taxonomy? Maybe we should add one. A method to rename taxonomic labels (by slicing, removing rank handles, etc) would actually be quite useful, e.g., for manually modifying taxonomy labels before or after classification.

@mikerobeson
Copy link
Collaborator Author

Not that I am aware. I know we previously discussed being able to parse / modify the taxonomy files. I suppose we can simply do that. Would definitely be much faster to slice and dice the taxonomy rather than re-processing.

@nbokulich
Copy link
Collaborator

okay let's go with slicing and dicing. it would be a fun function to write too! do you want to take this one or should I?

@mikerobeson
Copy link
Collaborator Author

Well, I do need more pandas practice so I can try tackling this one. Unless you think there is urgency to do this ASAP. :-)

@mikerobeson mikerobeson changed the title add option to keep original downloaded silva files? add option to keep original downloaded silva files and/or different taxonomy files? Jun 13, 2020
@nbokulich
Copy link
Collaborator

no urgency on this IMO... this will be a fun one for you 😄

@thermokarst
Copy link
Contributor

I love this idea. We have been talking about a cache-type system in QIIME 2 for a while. I think there are some issues floating around on qiime2/qiime2...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants