Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Wrap Rails integrations into AS::Callback #327

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

zealot128
Copy link
Contributor

This fixes an issue, where Datagrid loads Rails' stuff during initialization, which is not optimal in some cases,

See:

rails/rails#52740

In our case, the encryption config got loaded 'too late', because it was already loaded by several gems (such as Datagrid) before.

@bogdan
Copy link
Owner

bogdan commented Sep 24, 2024

Please add a changelog and it is fine.

@dev-alisson
Copy link

dev-alisson commented Sep 24, 2024 via email

@bogdan
Copy link
Owner

bogdan commented Sep 25, 2024

@dev-alisson setup notification filters in your email client to automatically move to trash certain emails that match criteria you want.

@bogdan bogdan merged commit 993c7c1 into bogdan:master Sep 27, 2024
7 checks passed
@zealot128
Copy link
Contributor Author

Awesome! Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants