Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code-corrections and cosmetic changes #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

buffcode
Copy link

This PR fixes the way links are generated during the redirect. Previous version did not support the "custom link parameter" setting by Typo3. When "permanent" is not checked, the extension will now emit a 302 "Temporarily moved" redirect header (previously always was 301).

Further more many smaller changes were made to clean up the code (removing comments, correct indenation, phpDoc comments).

Feel free to merge, used in production.

- Removed superfluous comments
- Changed formatting
- phpDoc comments
- Removed superfluous comments
- Changed formatting
- phpDoc comments
- Removed superfluous comments
- Changed formatting
- phpDoc comments
@bobosch
Copy link
Owner

bobosch commented Oct 29, 2015

Thanks for your help. I like to merge your program update and some cosmetic updates.
Unfortunately you have mixed up the cosmetic changes with the program changes in one commit.
Could you please send me a commit / diff with the program changes?

  • Spaces between commands and variables are good.
  • Space indentation has two disadvantages:
    • Every coder has a different attitude how much indentation. If you use tabs, everyone can configure the tab indentation in his IDE or file editor.
    • They makes the file bigger
  • The curly brackets should be in the same line

Please also take a look at the TYPO3 coding guideline https://docs.typo3.org/typo3cms/CodingGuidelinesReference/PhpFileFormatting/PhpSyntaxFormatting/Index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants