Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should a deregistered CPT or taxonomy continue due to overrides? #18

Open
bobbingwide opened this issue Oct 7, 2019 · 3 comments
Open
Assignees
Labels

Comments

@bobbingwide
Copy link
Owner

The download post type is registered by Easy-Digital-Downloads. I wanted to clone the content so added the capability using oik-types. Having created blocks for EDD, using oik-loader, I no longer need it to be activated. But when EDD is deactivated, the post type is still visible in the admin area. Should it be?

@bobbingwide bobbingwide self-assigned this Oct 7, 2019
@bobbingwide
Copy link
Owner Author

I changed the post type definitions for two post types and it worked.

WooCommerce scheduled-action - corrected the spelling of the description
Easy Digital Downloads - edd_payments - added a description.

@bobbingwide
Copy link
Owner Author

That’s a good question. This side effect would allow us to avoid the notices produced when WooCommerce is not active.

@bobbingwide
Copy link
Owner Author

Having recently developed oik-unloader I've found another reason for allowing the registration overrides to continue to register CPTs when the original plugins are deactivated. I'll need to try this for sites with WooCommerce where we still need products to be registered in order to get the correct permalinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant