From 7bc449011632299ed391e7e0db01493df37ec10d Mon Sep 17 00:00:00 2001 From: nekevss Date: Fri, 29 Sep 2023 21:14:30 -0400 Subject: [PATCH 1/3] Default features to true --- Cargo.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index 67f2e471102..933dea6ebe2 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -79,7 +79,7 @@ icu_segmenter = { version = "~1.3.0", default-features = false } icu_datagen = { version = "~1.3.0", default-features = false } icu_provider_adapters = { version = "~1.3.0", default-features = false } icu_provider_blob = { version = "~1.3.0", default-features = false } -icu_properties = { version = "~1.3.0", default-features = false } +icu_properties = { version = "~1.3.0", default-features = true } writeable = "~0.5.3" yoke = "~0.7.2" zerofrom = "~0.1.3" From 0fc5396e4b320c61d06323b6d7a5a28e892e41ac Mon Sep 17 00:00:00 2001 From: nekevss Date: Fri, 29 Sep 2023 23:26:28 -0400 Subject: [PATCH 2/3] Add member CI check --- .github/workflows/rust.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index cdfe3756210..31f6741a3ab 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -122,3 +122,14 @@ jobs: run: cargo build --quiet --profile ci - name: Run example classes run: cargo run --bin classes --profile ci + - name: Check Workspace Members + run: | + cargo check -p boa_ast + cargo check -p boa_cli + cargo check -p boa_gc + cargo check -p boa_icu_provider + cargo check -p boa_interner + cargo check -p boa_macros + cargo check -p boa_parser + cargo check -p boa_runtime + cargo check -p boa_wasm From 9603b897056024aa8f941ae4ed9937506a2d16cf Mon Sep 17 00:00:00 2001 From: nekevss Date: Fri, 29 Sep 2023 23:50:29 -0400 Subject: [PATCH 3/3] Move CI additions to Build and Test --- .github/workflows/rust.yml | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 31f6741a3ab..118a3bd08a3 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -65,6 +65,14 @@ jobs: run: cargo nextest run --profile ci --cargo-profile ci --features annex-b,intl,experimental - name: Test docs run: cargo test --doc --profile ci --features annex-b,intl,experimental + - name: Build boa_ast crate + run: cargo build -p boa_ast + - name: Build boa_cli crate + run: cargo build -p boa_cli + - name: Build boa_parser crate + run: cargo build -p boa_parser + - name: Build boa_runtime crate + run: cargo build -p boa_runtime msrv: name: Minimum supported Rust version @@ -122,14 +130,3 @@ jobs: run: cargo build --quiet --profile ci - name: Run example classes run: cargo run --bin classes --profile ci - - name: Check Workspace Members - run: | - cargo check -p boa_ast - cargo check -p boa_cli - cargo check -p boa_gc - cargo check -p boa_icu_provider - cargo check -p boa_interner - cargo check -p boa_macros - cargo check -p boa_parser - cargo check -p boa_runtime - cargo check -p boa_wasm