Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't publish boa_wasm to npm if version exists #4065

Open
jasonwilliams opened this issue Dec 5, 2024 · 0 comments
Open

Don't publish boa_wasm to npm if version exists #4065

jasonwilliams opened this issue Dec 5, 2024 · 0 comments
Labels
E-Easy Easy Internal Category for changelog

Comments

@jasonwilliams
Copy link
Member

We sometimes need to re-publish the same release which means publishing the same version. Cargo will ignore publishing a crate if it already exists but npm still fails.

It would be nice to have npm not fail if the version was already uploaded to the registry

our workflow lives here:
https://github.com/boa-dev/boa/blob/main/.github/workflows/release.yml#L39-L70

I guess we would want a step that runs npm view @boa-dev/boa_wasm version then checks the value against the current version (from Cargo.toml) if they match exit the workflow without any errors

@jasonwilliams jasonwilliams added E-Easy Easy Internal Category for changelog labels Dec 5, 2024
@jasonwilliams jasonwilliams changed the title Don't publish npm wasmt package if version exists Don't publish boa_wasm to npm if version exists Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Easy Easy Internal Category for changelog
Projects
None yet
Development

No branches or pull requests

1 participant