Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert property attributes #1423

Open
HalidOdat opened this issue Jul 22, 2021 · 2 comments
Open

Invert property attributes #1423

HalidOdat opened this issue Jul 22, 2021 · 2 comments
Labels
API execution Issues or PRs related to code execution technical debt

Comments

@HalidOdat
Copy link
Member

Currently we have the Attribute which by default is READONLY, NON_ENUMERABLE and PERMANENT. Which means when we create a for example a data descriptor with only Attribute::READONLY (DataDescriptor::new(value, Attribute::READONLY)), One would expect it to be READONLY, ENUMBERABLE and CONFIGURABLE, but in reality it is READONLY, NON_ENUMERABLE and PERMANENT which is counter intuitive.

This is similar to what V8 does.
@HalidOdat HalidOdat added technical debt execution Issues or PRs related to code execution API labels Jul 22, 2021
@HalidOdat HalidOdat self-assigned this Jul 22, 2021
@Razican
Copy link
Member

Razican commented Jan 31, 2022

@HalidOdat any news on this? Do you want me to un-assign it from you?

@HalidOdat
Copy link
Member Author

@HalidOdat any news on this? Do you want me to un-assign it from you?

Maybe after #1373 I can start working on this, but until then I'll un-assign myself, if anyone wants to claim it.

@HalidOdat HalidOdat removed their assignment Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API execution Issues or PRs related to code execution technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Razican @HalidOdat