-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop_incomplete_segments() - new option to remove only if all channels are NA #164
Comments
Sure, that seems straightforward. |
Yes it does. :) It is based on your code, just changed all-not-NA to any-not-NA and got rid of |
ok, then feel free to make a pull request to the experimental branch ;) Do you want to give it a try? also I'm slowly making my internal functions to be based on data table, to speed up things, if you want to code it in data table, you're more than welcome. |
Sure, I'll be happy to give it a try after I'm done with moving. |
Not sure if you're still using the package. If so, is this still relevant? |
At present
drop_incomplete_segments()
drops the segment if any channel is NA. It would be useful to have a parameter to remove segments only if all channels are NA.so the logic would be the following:
The text was updated successfully, but these errors were encountered: