Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing convergence criterion to match CRAN package? #3

Open
rybern opened this issue Feb 26, 2016 · 1 comment
Open

Changing convergence criterion to match CRAN package? #3

rybern opened this issue Feb 26, 2016 · 1 comment

Comments

@rybern
Copy link
Contributor

rybern commented Feb 26, 2016

Hi Brett,

What do you think about changing the convergence criterion to match the CRAN package? It's described briefly here on page 2 (see the "thr" parameter).

Is your alpha parameter is the same as their rho parameter?

Thanks for looking at my other pull requests. I might make a couple more, I hope I'm not annoying!

Edit: To clarify, I'm happy to make the changes, I'd just like your opinion on the idea

Thanks,
Ryan

@bnaul
Copy link
Owner

bnaul commented Feb 26, 2016

Sure, makes sense to me; I think that's just a scale-invariant version of the same criterion, which seems like a desirable property.

Thanks for the contributions! Keep 'em coming 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants