-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to set the filename's used for create_patch
and merge
#2
Comments
I was looking at implementing this because I'd like it in guppy, and I'm wondering whether we need to treat filenames slightly differently than we do not. I did some investigation and it looks like
prints diff --git "a/foobar\224" "b/foobar\224"
new file mode 100644
index 0000000..e69de29 Think maybe we should do the same thing, unless there's another use case I might be missing. |
Ah nvm:
prints filenames without escaping them. Oh well. |
I was wondering the same, For other people running into this issue, there's a crate that can be used in the meantime: https://crates.io/crates/diffy-fork-filenames |
Right now users are unable to set their own filenames, which appear when displaying a patch or when a merge has conflicts. There should be some interface which makes it easy for user's to overwrite the currently used defaults. A few options include:
DiffOptions
andMergeOptions
File
which is a tuple (filename, contents) which are passed into thecreate_patch
andmerge
methods instead of just passing in their contents.The text was updated successfully, but these errors were encountered: