Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys for reserved formats in other languages #1100

Open
alanb2718 opened this issue Oct 24, 2024 · 3 comments
Open

keys for reserved formats in other languages #1100

alanb2718 opened this issue Oct 24, 2024 · 3 comments
Labels
bug Something isn't working new-ui

Comments

@alanb2718
Copy link
Collaborator

alanb2718 commented Oct 24, 2024

There are three reserved formats: HY, TC, and VM. These are used for the venue type. (They shouldn't really be formats at all, but later for fixing that.) In the old UI, the keys for these in the English translation are read-only in the UI. However, you can edit the key in other languages. This seems correct since there might be a better key in those cases. Further, you can edit the name and description for the reserved format in any language, including English

In the new UI you can't change the key in any language -- the root server API must be checking for this. Should be able to change the key for non-English translations. Also, you can't change the name or description either in English.

@alanb2718 alanb2718 added bug Something isn't working new-ui labels Oct 24, 2024
@alanb2718
Copy link
Collaborator Author

A related bug: it looks like the root server API is preventing making any edits to the English version of one of the reserved formats. The user should be able to change the name or description, although not the key.

@alanb2718
Copy link
Collaborator Author

After these are fixed, check that the changes made in PR #1103 are OK still.

@alanb2718
Copy link
Collaborator Author

Yet another issue: in a non-English language, you can change the key for some random format to be HY, TC, or VM. The new API gives an error if you try to do this. It would definitely be an odd thing to change to one of these keys, but not sure why it needs to be an error. If it stays an error, the new UI should check for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new-ui
Projects
None yet
Development

No branches or pull requests

1 participant