New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long version refactor #5

Open

krzysztofrewak opened this issue Sep 18, 2024 · 0 comments

Member

krzysztofrewak commented Sep 18, 2024

I think differences here could be more verbose:

$version = (new Version())->generate();
$version = (new Version(true))->generate();

Maybe this would be better?

$version = (new Version())->generate();
$version = (new LongVersion())->generate();

Also: 35. and 38. line in src/Version.php are repeated. If you're using long version, you shouldn't run normal one, I think.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment