New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check eslint rulesets #25

Open

krzysztofrewak opened this issue Jan 11, 2023 · 0 comments

Labels

Member

krzysztofrewak commented Jan 11, 2023

There are still multiple codestyle issues here like missing curly braces or unneccessary spaces:

    for(const meetup of selectedMeetups) {
      if(new Date(meetup.date) >= today ) {
      futureMeetups.push(meetup)
    }
    else 
      oldMeetups.push(meetup)
    }

    function compare( a, b ) {
      if ( a.date < b.date ) {
        return -1
      }
      if ( a.date > b.date ) {
        return 1
      }
      return 0
    }

I think eslint should cover all these cases.

Originally posted by @krzysztofrewak in #24 (comment)

krzysztofrewak added the environment label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment