Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#50 - CRUD for schools frontend #104

Open
wants to merge 113 commits into
base: main
Choose a base branch
from
Open

#50 - CRUD for schools frontend #104

wants to merge 113 commits into from

Conversation

AmonDeShir
Copy link
Collaborator

@AmonDeShir AmonDeShir commented Nov 9, 2024 •
edited
Loading

Should close #11 and close #50 and close #113.

PC

image

Mobile

image

AmonDeShir and others added 30 commits October 21, 2024 12:50
@AmonDeShir
create basic crud layout
599e3f3
@JokeUrSelf
refactor: decouple from 'demo' and '87-login-page-improvements' branches
8c831c0
@JokeUrSelf
fix: duration input is cut when expanding the test
e9c5ba3
@JokeUrSelf
fix: duration can be set to number the exceeds the max limit
2df9491
@JokeUrSelf
fix: remove copying for multiple quizzes
02d21cd
@JokeUrSelf
fix: delete button deletes all questions
44d976f
@JokeUrSelf
style: answer check button color and position
ecce6b4
@JokeUrSelf
style: create new answers with empty content
9cbc5fb
@JokeUrSelf
build: update packages
27caa34
@JokeUrSelf
fix: linting
6289fa1
@JokeUrSelf
chore: merge button logic
b590f15
@JokeUrSelf
fix: remove time limits for datepicker
d2d0d0f
@JokeUrSelf
fix: error message is not fully visible
6729c1e
@JokeUrSelf
fix: schedule_at error message contains untranslated word 'now'
6b3009f 
fix: make fix
@JokeUrSelf
fix: wrong interpritation of time after quiz update
71d75d2 
fix
@JokeUrSelf
style: add animation to quizzes occurence
ef5c86a
@JokeUrSelf
format: remove unused import
ba61f3c
@JokeUrSelf
style: add animations for icon-buttons
d0d09b7
@JokeUrSelf
apply suggestion: change 'Stworzony' na 'Utworzony'
d8f7f79
@JokeUrSelf
fix: sorting isn' t preserved after page reload
768c34a
@JokeUrSelf
fix: deletion alert doesn't close when clicking "Usuń"
16e7702
@JokeUrSelf
chore: preserve state and scroll in request components by default
3b6b0ac
@JokeUrSelf
fix: seeder creates quizzes that can't exist
6db15d5
@JokeUrSelf
feat: add placeholders for empty textareas
8d27ffb
@JokeUrSelf
fix: "Zaproś uczestników" redirects to entry that doesn't yet exist
d1af3e9
@JokeUrSelf
fix: typo in "Zaproś uczestników"
949ad49
@JokeUrSelf
feat: add sorting by modification
9f5255a
@JokeUrSelf
feat: make pre-publish validation message more specific
c3a8e97
@JokeUrSelf
fix: publish button doesn't switch its state
5b765ff
@JokeUrSelf
feat: add " - kopia" to the end of the tile of a copied quiz
b81932f
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please work on empty state, because now it looks... sad

image

  1. When I fill search I have to click on magnifying glass or press Enter - I think this serach should work without clicking - when user enters the text, it should search with some delay

  2. I believe it should be "nazwa"

image

  1. Please fix warnings in console

image

  1. When I click "x" icon nothing happens

@EwelinaSkrzypacz
Copy link
Member

Conflicts :(

@AmonDeShir
Copy link
Collaborator Author

AmonDeShir commented Nov 26, 2024 •
edited
Loading

  1. Please work on empty state, because now it looks... sad

Fixed.

  1. When I fill search I have to click on magnifying glass or press Enter - I think this serach should work without clicking - when user enters the text, it should search with some delay

Fixed.

  1. I believe it should be "nazwa"

Fixed.

  1. Please fix warnings in console

Fixed.

  1. When I click "x" icon nothing happens

Fixed.

EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Nov 26, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I click this button ✔️ (in creating school form) I see 404 error.

  2. Please fix warning in console

image

resources/js/Pages/Admin/Quizzes.vue Outdated Show resolved Hide resolved
resources/js/components/Crud/CrudPage.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JokeUrSelf JokeUrSelf Awaiting requested review from JokeUrSelf

@dawidrudnik dawidrudnik Awaiting requested review from dawidrudnik

@EwelinaSkrzypacz EwelinaSkrzypacz Awaiting requested review from EwelinaSkrzypacz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Pagination, Sorting, Search, and Filtering CRUD for schools - Frontend CRUD for schools
3 participants
@AmonDeShir @EwelinaSkrzypacz @JokeUrSelf