Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9 - Add helper for nullable strings #30

Merged
merged 4 commits into from
Jun 7, 2024
Merged

#9 - Add helper for nullable strings #30

merged 4 commits into from
Jun 7, 2024

Conversation

PiotrFedak
Copy link
Contributor

@PiotrFedak PiotrFedak commented Jun 5, 2024 •
edited
Loading

This should close #9

Added helper methods for handling nullable strings and boolean conversion in Behat tests

  • NullableHelper::behatNull to handle "null" strings.
  • BooleanHelper::toBoolean to convert string values to boolean.
  • Also i added some simple test for both helpers

@PiotrFedak PiotrFedak changed the title #9 Add helper for nullable strings #9 - Add helper for nullable strings Jun 5, 2024
@PiotrFedak PiotrFedak marked this pull request as ready for review June 5, 2024 09:19
@PiotrFedak PiotrFedak linked an issue Jun 5, 2024 that may be closed by this pull request
Add helper for nullable strings #9
Closed
AleksandraKozubal
AleksandraKozubal reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@AleksandraKozubal AleksandraKozubal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please improve consistency in helpers naming

@PiotrFedak PiotrFedak merged commit 327a638 into main Jun 7, 2024
1 check passed
@PiotrFedak PiotrFedak deleted the #9-Add-helper-for-nullable-strings branch June 7, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlowski11 orlowski11 orlowski11 approved these changes

@AleksandraKozubal AleksandraKozubal AleksandraKozubal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add helper for nullable strings
3 participants
@PiotrFedak @AleksandraKozubal @orlowski11