Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "target" command select between NC and EC target #700

Open
mgroeber9110 opened this issue Nov 15, 2024 · 1 comment
Open

Make "target" command select between NC and EC target #700

mgroeber9110 opened this issue Nov 15, 2024 · 1 comment

Comments

@mgroeber9110
Copy link
Contributor

Currently, the target command always launches the target from the local/gbuild directory. This makes it difficult to switch between NC and EC builds easily when working in parallel with both types of targets.

To simplify this, I have been using the following setup for my local development, and it may be worth adding to the repository as a standard:

  • The target comamand by default launches the target from local/gbuild.ec. When calling it with target -n, it launches from local/gbuild instead.
    • I chose this because it mirrors the -n switch in pmake to build an NC version of a Geode
    • Also, having EC as the default may be even more useful for Watcom because the NC build currently has no useful local symbols.
  • The buildbbx.pl script is changed so that it suggests taget/gbuild.ec as the default target directory when building an EC version, and target/gbuild for an NC version

This would push people towards a standard naming convention for NC/EC target locations, and make launching one or the other easier.

If acceptable, the main question might be whether this change breaks anything in the nightly build system.

@bluewaysw
Copy link
Owner

Sounds good to me, I think there is not impact to then CI process because of all parameter are passed from the outside in that case. But isn't the buildbbx command not saving and reusing the values entered the last time? If so, default gbuild/gbuild.ec might fail if nc/ec build run are mixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants