From 1ae19f3e18d61db276d5e0fd4b87f7845719ed7d Mon Sep 17 00:00:00 2001 From: Francesco Biscani Date: Mon, 16 Dec 2024 11:34:22 +0100 Subject: [PATCH] Move the workaround. --- .circleci/config.yml | 6 ++++++ tools/circleci_conda_asan.sh | 5 ----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 642250ecb..3f92bbf66 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -8,6 +8,12 @@ jobs: resource_class: large steps: - checkout + # NOTE: temporary workaround for asan failures with too + # much entropy. See: + # https://github.com/google/sanitizers/issues/1614 + - run: + name: Fix mmap_rnd_bits for asan + command: sudo sysctl vm.mmap_rnd_bits=28 - run: name: Build and test command: bash ./tools/circleci_conda_asan.sh diff --git a/tools/circleci_conda_asan.sh b/tools/circleci_conda_asan.sh index defb7cf05..f0ef901e4 100644 --- a/tools/circleci_conda_asan.sh +++ b/tools/circleci_conda_asan.sh @@ -9,11 +9,6 @@ set -e # Core deps. sudo apt-get install wget -# NOTE: temporary workaround for asan failures with too -# much entropy. See: -# https://github.com/google/sanitizers/issues/1614 -sudo sysctl vm.mmap_rnd_bits=28 - # Install conda+deps. wget https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-Linux-x86_64.sh -O miniconda.sh export deps_dir=$HOME/local