Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve video download pipeline to guarantee (as much as possible) that recorded videos are not lost #715

Closed
rafaellehmkuhl opened this issue Jan 31, 2024 · 4 comments · Fixed by #720
Assignees
Labels
enhancement New feature or request must-have Must have feature or change P0 - Critical Priority Highest priority over all priorities ux Has to do with the user experience

Comments

@rafaellehmkuhl
Copy link
Member

We had a recent report from Peter that he did some video recording and the download failed, resulting in him losing his footage.

This is probably one of the worst possible situations for the user, as you can't simply film something again.

Cockpit should do whatever is in its hands to prevent this kind of problem.

The first thing that comes to my mind is simply not auto-deleting video recordings. Not even if we had the download confirmed (we can't know if it had actually finished with success). We should always stay with the footage in the disk, and let the user know that there are footage there that can be deleted if necessary.

@rafaellehmkuhl rafaellehmkuhl added enhancement New feature or request must-have Must have feature or change P0 - Critical Priority Highest priority over all priorities ux Has to do with the user experience labels Jan 31, 2024
@rafaellehmkuhl rafaellehmkuhl self-assigned this Jan 31, 2024
@pkmiles
Copy link

pkmiles commented Feb 1, 2024

Thanks @rafaellehmkuhl . Looks like a good solution. You could even have a "space remaining" mini widget - akin to how GoPro shows you how much is left on your SD card.

Aside: I posted that on the forum because I wasn't sure at that point of whether to raise it as an issue, plus I thought it might be useful for the wider user community to understand the core capability of Cockpit regarding video recording. Let me know if that's a problem - I can understand you may not want to expose the wider group to the sausage making that goes on while products in beta.

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Feb 1, 2024

Hey @pkmiles! No problem posting on the forum, really. It's indeed good that we have this kind of discussion there (your points on what's the goal with the recording functionality specially). Feel free to open the topics there or the issues directly here. I will do my best to organize them afterwards. We are also not sure yet on what exactly should go on the Discuss vs Discord vs Github 😄

About the "space remaining" widget, I think that's a great idea! Can you open a separate issue to track the development of it?

@pkmiles
Copy link

pkmiles commented Feb 1, 2024

Another thought. Maybe the way video management could work is, rather than downloading after you stop recording, storing them on the ROV (with the memory mini widget so you know when you're nearing full) and then requiring a specific action to download. After download complete (and ideally validated), the user then has the option to remove the videos from storage (freeing up space).

This experience would be akin to pulling an SD Card out of GoPro, transferring the videos, ensuring they're all there and then deleting them off the card (or reformatting the card).

Thoughts?

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Feb 2, 2024

About the "record and then decide what to do" experience, that's actually exactly what I was proposing yesterday in our internal meeting 😃

To start, we would keep the video being stored on the browser DB (a.k.a. your computer's disk), as it's not yet well-defined in BlueOS how the extensions should hold temporary files, but as soon as we decide that for BlueOS, I think we should move the videos also there (as it's being done in #701 for Cockpit's settings).

Opened #719 to track that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request must-have Must have feature or change P0 - Critical Priority Highest priority over all priorities ux Has to do with the user experience
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants