Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't have a Cockpit Action for the most important feature: recording videos #656

Closed
rafaellehmkuhl opened this issue Dec 22, 2023 · 4 comments · Fixed by #737
Closed
Assignees
Labels

Comments

@rafaellehmkuhl
Copy link
Member

We should add it, and in a way that the user can use it just with the joystick.

With the current MiniVideoRecorder behavior, the user would have to also click to select the desired stream to be recorded, but this adds 3 more clicks and the need to use the mouse/touchpad.

@rafaellehmkuhl rafaellehmkuhl added the P1 - Important Priority High priority task label Dec 22, 2023
@rafaellehmkuhl rafaellehmkuhl added this to the FromBetaToStable milestone Dec 22, 2023
@ES-Alexander
Copy link
Contributor

Is this a duplicate of #610?

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Jan 16, 2024

Is this a duplicate of #610?

I think it's one of those cases where your issue is wider 😅
I think we can keep both and finish yours only when both recording and snapshots are implemented, so we don't do what we did in the last ones, where I finished your issue, but there were actually a lot more features there that didn't get implemented on the linked PR.

@rafaellehmkuhl
Copy link
Member Author

@ES-Alexander @pkmiles any ideas on how that should work?

I'm thinking of something like having a video recording action that is configurable.

  • It could be used without being configured, in which case it would only work if there's only one stream available;
  • If there's more than one stream available and it is not configured, it will trigger start/stop recording on all streams;
  • The user will be able to associate the action to an specific stream, doing it on the video configuration page, or in an actions' configuration page;
  • The user would be able to create many of those actions, one for each stream, to be able to control then individually;
  • Alerts for start/stop of those would be emited so the user can have a feedback about what exactly is going on (e.g.: "Started recording stream 0", "Stopped recording stream 2", "Started recording all streams", etc);

What do you guys think?

@rafaellehmkuhl
Copy link
Member Author

Will close this one with #737 and open a new one referring to this, about adding the ability to record specific streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
2 participants