Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<s>Rails 5.1<s> rails-ujs support #34

Open
joseramonc opened this issue Nov 10, 2017 · 3 comments
Open

<s>Rails 5.1<s> rails-ujs support #34

joseramonc opened this issue Nov 10, 2017 · 3 comments

Comments

@joseramonc
Copy link
Contributor

Rails 5.1 shows default confirm dialog
@rvanlieshout
Copy link
Member

Ah. They really did change a lot in Rails 5.1. We'll try to get this resolved

@rvanlieshout
Copy link
Member

In rails-ujs (actionview/app/assets/javascripts/features/confirm.coffee) they bind an anonymous function to document that calls a local allowAction and not $.rails.allowAction (or Rails.allowAction).

It'll be hard to get this fixed without a change in that file.

More to follow

@rvanlieshout rvanlieshout changed the title Rails 5.1 support <s>Rails 5.1<s> rails-ujs support May 20, 2019
@rvanlieshout
Copy link
Member

Did research: we should use something other then data-confirm (e.g. data-confirm-bs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rvanlieshout @joseramonc