Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN-003 - Rsa crate dependency timing side channel #127

Open
morganava opened this issue Nov 12, 2024 · 2 comments
Open

CLN-003 - Rsa crate dependency timing side channel #127

morganava opened this issue Nov 12, 2024 · 2 comments
Labels
bug Something isn't working gosling gosling crate issue sponsor 5 Funded by Sponsor 5 (Q2 2023)

Comments

@morganava
Copy link
Collaborator

Description:

The rsa crate is subject to a timing side channel attack.

Technical description:

The rsa crate is susceptible to a Marvin attack (https://www.redhat.com/en/blog/marvin-attack) tracked here https://rustsec.org/advisories/RUSTSEC-2023-0071.html, which takes advantage of non-constant time operations in RSAES-PKCS1-v1_5. The Gosling crates do not directly use the vulnerable methods.

Impact:

The jitter of the Tor network makes such a vulnerability even harder to exploit, but if it were to be exploited then confidentiality could be compromised.

Recommendation:

  • There is currently no patch available. Keep abreast of new developments and update the dependency once a fix is available.
@morganava morganava added bug Something isn't working sponsor 5 Funded by Sponsor 5 (Q2 2023) gosling gosling crate issue labels Nov 12, 2024
@morganava
Copy link
Collaborator Author

morganava commented Nov 12, 2024

Furthermore, this upstream crate is only enabled when the ArtiClintTorClient TorProvider is enabled (which bings in the arti-client crate and all its dependencies).

We will automatically get a fix for this when the Tor Project updates their arti-client's dependencies after the rsa crate pushes a fix for their bug.

@morganava
Copy link
Collaborator Author

This issue is being tracked ultimately upstream here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gosling gosling crate issue sponsor 5 Funded by Sponsor 5 (Q2 2023)
Projects
None yet
Development

No branches or pull requests

1 participant