Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application::TEXTDOMAIN constant has been removed, but required #3

Open
BenceSzalai opened this issue May 19, 2021 · 0 comments · May be fixed by #4
Open

Application::TEXTDOMAIN constant has been removed, but required #3

BenceSzalai opened this issue May 19, 2021 · 0 comments · May be fixed by #4

Comments

@BenceSzalai
Copy link

It looks like the Application::TEXTDOMAIN constant has been removed here, but it is required in:

  • vendor/themosis/framework/src/Forms/Fields/Types/CollectionType.php
  • vendor/themosis/framework/src/Forms/Fields/Types/ColorType.php
  • vendor/themosis/framework/src/Forms/Fields/Types/MediaType.php
  • vendor/themosis/framework/src/Metabox/Factory.php

Steps to reproduce

E.g.: try to use the Field::choice() method: it will generate an exception.

Expected behavior

Application::TEXTDOMAIN is not removed and the classes listed above work fine.
BenceSzalai added a commit to BenceSzalai/themosis-framework that referenced this issue May 20, 2021
@BenceSzalai
Fix: add back Application::TEXTDOMAIN constant
fdf4308 
blueoceanideas#3
@BenceSzalai BenceSzalai linked a pull request May 20, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: add back Application::TEXTDOMAIN constant BenceSzalai/themosis-framework
1 participant
@BenceSzalai