Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSS vars and refactor Tailwind brand values for robustness #61

Open
tarinrickett opened this issue Jan 21, 2025 · 2 comments
Open

Comments

@tarinrickett
Copy link
Contributor

tarinrickett commented Jan 21, 2025

Currently, our Tailwind CSS brand values are specific to the colors they represent; e.g., bluedot-lighter.

I would like us to adopt a more generic naming system, e.g. bluedot-primary, bluedot-secondary, etc. so that we are set up to adapt more rapidly to changing design system requirements.

I recommend doing this in a backwards compatible manner; i.e., add the new values to the existing list and map them all to CSS vars:

        colors: {
          bluedot: {
-            normal: '#0037FF',
+           normal: var(--bluedot-normal),
+           primary: var(--bluedot-normal),
          },

Open to discussion here!


This is not just for color tokens – we should also update for standard grid sizes (incl. width, padding, margins, etc.), font sizes (s/m/l), etc.

@tarinrickett tarinrickett moved this to Backlog in Website 2025 Jan 21, 2025
@tarinrickett tarinrickett changed the title Refactor Tailwind values for robustness Add CSS vars and refactor Tailwind values for robustness Jan 21, 2025
@tarinrickett tarinrickett changed the title Add CSS vars and refactor Tailwind values for robustness Add CSS vars and refactor Tailwind brand values for robustness Jan 21, 2025
@domdomegg
Copy link
Member

sgtm

@tarinrickett
Copy link
Contributor Author

Blocked

Waiting on definitions from UX. ETA EOW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

2 participants