Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move of a local object prevents copy elision #21

Open
dpiparo opened this issue Jul 18, 2016 · 2 comments
Open

Move of a local object prevents copy elision #21

dpiparo opened this issue Jul 18, 2016 · 2 comments

Comments

@dpiparo
Copy link
Contributor

dpiparo commented Jul 18, 2016

Hi,

the file include/blond/fft.h presents at line 340 an issue.
A move of a local object is in place which prevents copy elision: http://www.cplusplus.com/forum/general/186411 .
To avoid performance hits, one might consider to simply return the collection.

Cheers,
D
@kiliakis
Copy link
Collaborator

@dpiparo I really wasn't aware of that issue, commit c34ee86 is taking care of this

@dpiparo
Copy link
Contributor Author

dpiparo commented Jul 19, 2016

Hi @kiliakis,

thanks. Do you see an effect when profiling before and after c34ee86?

Cheers,
D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dpiparo @kiliakis