Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary comment in "configuratorwindow.cpp", line 818 #5

Open
samuelfmlourenco opened this issue Oct 26, 2024 · 0 comments
Open
Assignees
Labels
invalid This doesn't seem right

Comments

@samuelfmlourenco
Copy link
Member

samuelfmlourenco commented Oct 26, 2024

There is a comment in "configuratorwindow.cpp", line 818, that is unnecessary and only adds confusion. The entire line where the comment is located is as follows:

mcp2210_.close(); // If the device is already closed, this will have no effect

That line is located inside handleError(), and the only instance of a call to mcp2210_.close() is inside this same function. So, the device is never closed elsewhere, and handleError() is never called concurrently. Thus, the comment makes no sense and should be removed.

@samuelfmlourenco samuelfmlourenco added the invalid This doesn't seem right label Oct 26, 2024
@samuelfmlourenco samuelfmlourenco self-assigned this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant