From c539d21527bb2956a6629c9370a0ceb8c018e868 Mon Sep 17 00:00:00 2001
From: dragonmux <git@dragonmux.network>
Date: Tue, 31 Oct 2023 06:46:47 +0000
Subject: [PATCH] windows/serialInterface: Implemented the logic for opening
 communications with a target BMP and configuring it properly

---
 src/windows/serialInterface.cxx | 74 ++++++++++++++++++++++++++++++---
 1 file changed, 69 insertions(+), 5 deletions(-)

diff --git a/src/windows/serialInterface.cxx b/src/windows/serialInterface.cxx
index 496ff6c..a9eefec 100644
--- a/src/windows/serialInterface.cxx
+++ b/src/windows/serialInterface.cxx
@@ -138,8 +138,76 @@ struct hklmRegistryKey_t
 	return portName;
 }
 
-serialInterface_t::serialInterface_t(const usbDevice_t &usbDevice)
+serialInterface_t::serialInterface_t(const usbDevice_t &usbDevice) : device
+	{
+		[&]()
+		{
+			// Figure out what the device node is for the requested device
+			const auto portName{findBySerialNumber(usbDevice)};
+			if (portName.empty())
+				return INVALID_HANDLE_VALUE;
+
+			// Try and open the node so we can start communications with the the device
+			return CreateFile
+			(
+				portName.c_str(),                               // UNC path to the target node
+				GENERIC_READ | GENERIC_WRITE,                   // Standard file permissions
+				0,                                              // With no sharing
+				nullptr,                                        // Default security attributes
+				OPEN_EXISTING,                                  // Only succeed if the node already exists
+				FILE_ATTRIBUTE_NORMAL | FILE_FLAG_NO_BUFFERING, // Normal but unbuffered I/O
+				nullptr                                         // No template file
+			);
+		}()
+	}
+{
+	// If opening the device node failed for any reason, error out early
+	if (device == INVALID_HANDLE_VALUE)
+	{
+		handleDeviceError("open device"sv);
+		return;
+	}
+
+	// Get the current device state from the device
+	DCB serialParams{};
+	serialParams.DCBlength = sizeof(DCB);
+	if (!GetCommState(device, &serialParams))
+	{
+		handleDeviceError("access communications state from device"sv);
+		return;
+	}
+
+	// Adjust the device state to enable communications to work and be in the right mode
+	serialParams.fParity = false;
+	serialParams.fOutxCtsFlow = false;
+	serialParams.fOutxDsrFlow = false;
+	serialParams.fDtrControl = DTR_CONTROL_ENABLE;
+	serialParams.fDsrSensitivity = false;
+	serialParams.fOutX = false;
+	serialParams.fInX = false;
+	serialParams.fRtsControl = RTS_CONTROL_DISABLE;
+	serialParams.ByteSize = 8;
+	serialParams.Parity = NOPARITY;
+	if (!SetCommState(device, &serialParams))
+	{
+		handleDeviceError("apply new communications state to device"sv);
+		return;
+	}
+
+	COMMTIMEOUTS timeouts{};
+	timeouts.ReadIntervalTimeout = 10;
+	timeouts.ReadTotalTimeoutConstant = 10;
+	timeouts.ReadTotalTimeoutMultiplier = 10;
+	timeouts.WriteTotalTimeoutConstant = 10;
+	timeouts.WriteTotalTimeoutMultiplier = 10;
+	if (!SetCommTimeouts(device, &timeouts))
+		handleDeviceError("set communications timeouts for device"sv);
+}
+
+serialInterface_t::~serialInterface_t() noexcept
 {
+	if (device != INVALID_HANDLE_VALUE)
+		CloseHandle(device);
 }
 
 void serialInterface_t::handleDeviceError(const std::string_view operation) noexcept
@@ -158,10 +226,6 @@ void serialInterface_t::handleDeviceError(const std::string_view operation) noex
 	device = INVALID_HANDLE_VALUE;
 }
 
-serialInterface_t::~serialInterface_t() noexcept
-{
-}
-
 void serialInterface_t::swap(serialInterface_t &interface) noexcept
 {
 	std::swap(device, interface.device);