From 665f83f346b8cd4e7991c6fe93a85a33b3885651 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Gra=C3=A7a=20Silva?= Date: Tue, 19 Sep 2023 22:31:04 +0100 Subject: [PATCH] workflows: declare empty BUILD_OPTS While reading the workflow files without previous knowledge the use BUILD_OPTS variable is confusing, it's not clear where it comes from, or if it even is populated, this makes it clear it is just a statically empty variable for now, and can be populated if needed in the future --- .github/workflows/build-linux.yml | 2 ++ .github/workflows/build-macos.yml | 2 ++ .github/workflows/build-windows.yml | 5 ++++- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml index 8dadea8..95715d8 100644 --- a/.github/workflows/build-linux.yml +++ b/.github/workflows/build-linux.yml @@ -30,6 +30,8 @@ jobs: - 'gcc-12' - 'gcc-13' fail-fast: false + env: + BUILD_OPTS: '' steps: - name: Runtime environment shell: bash diff --git a/.github/workflows/build-macos.yml b/.github/workflows/build-macos.yml index 537dd68..3b91ea7 100644 --- a/.github/workflows/build-macos.yml +++ b/.github/workflows/build-macos.yml @@ -105,6 +105,8 @@ jobs: - gcc@12 - gcc@13 # needs hardcoding for the GCOV replacement fail-fast: false + env: + BUILD_OPTS: '' steps: - name: Runtime environment env: diff --git a/.github/workflows/build-windows.yml b/.github/workflows/build-windows.yml index 34ebe2b..a53fc14 100644 --- a/.github/workflows/build-windows.yml +++ b/.github/workflows/build-windows.yml @@ -29,6 +29,7 @@ jobs: CC: cl.exe CXX: cl.exe LD: link.exe + BUILD_OPTS: '' steps: - name: Runtime environment env: @@ -111,6 +112,8 @@ jobs: - ucrt64 - clang64 fail-fast: false + env: + BUILD_OPTS: '' steps: - name: Use MinGW from MSYS uses: msys2/setup-msys2@v2 @@ -154,7 +157,7 @@ jobs: meson --version ninja --version - name: Configure - run: meson build --prefix=$HOME/.local + run: meson build --prefix=$HOME/.local $BUILD_OPTS - name: Build run: meson compile -C build - name: Test