Skip to content

Contributing

Gareth McMullin edited this page Aug 27, 2019 · 6 revisions

General

Patch Policy (draft)

  • @gsmcmullin and @esden are general maintainers. We have push rights and will merge approved patches.
  • Any patch that fails to build in CI may be ignored.
  • Because we can't test all possible hardware platforms, we will need target specific maintainers to test and approve non-trivial changes to target support code.
  • Trivial patches such as adding a device ID to a switch statement may be merged without approval.
  • All existing code may be assumed to be maintained by @gsmcmullin or @esden, as patches appear that we can't test we will ask for a volunteer maintainer on Gitter or approach someone directly based on git history of the code in question.
  • Patches for new targets that don't affect existing targets will be merged without further testing assuming they conform to style and don't do anything stupid. The author becomes the maintainer for that target.
  • If the code is orphaned and no maintainer can be found in reasonable time, the patch author may take over as the new maintainer.
  • The current maintainer should be noted in the copyright banner at the top of the file in question.
  • The Github request review feature of pull requests should be used to request a review from the maintainer.

Wiki pages with specific dev info

NOTICE: The content of this wiki has been moved to http://black-magic.org website. Please update your links.

Clone this wiki locally