Add support for nRF54L #2009
Merged
Add support for nRF54L #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
requested changes
Dec 1, 2024
|
Review comments addressed, and I also improved the RRAM routines to use the write buffer, and added a benchmark to my test script to measure the performance: |
dragonmux
reviewed
Dec 3, 2024
There was a problem hiding this comment.
This is definitely a step in the right direction, nice work! Most of our review notes this round are stylistic in nature.
Please drop target/ from your commit messages as, per the contribution guidelines, it's not to be included in the prefix.
After those things have been taken care of we think this'll be ready for merge so we can get early nRF54L support in 😄
MDM is a NXP-specific term, Nordic calls it a CTRL-AP.
dragonmux
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This PR adds support for nRF54L.
The functionality of this PR has been tested through an automated test script published here:
Your checklist for this pull request
Closing issues
N/A