Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute Tab button too big on Pinned Tabs #1003

Open
2 of 9 tasks
ghnp5 opened this issue Oct 9, 2024 · 12 comments
Open
2 of 9 tasks

Mute Tab button too big on Pinned Tabs #1003

ghnp5 opened this issue Oct 9, 2024 · 12 comments
Labels
Issue::Bug Something isn't working

Comments

@ghnp5
Copy link

ghnp5 commented Oct 9, 2024

Describe the bug

Hi!

The Mute Tab button is a bit obtrusive in pinned tabs, as they take a lot of space, making it hard to click to open the tab.

image

image

Would it be possible to make it smaller? :)

Many thanks!

Expected behavior

No response

Screenshots

No response

OS

Windows 11

OS - Others

No response

Firefox Version

132.0b5 (64-bit)

Distribution

Theme

Theme - More Info

No response

user.js setup

user.js setup is just the default - no changes

Additional context

No response

@ghnp5 ghnp5 added the Issue::Bug Something isn't working label Oct 9, 2024
@ctrlcmdshft
Copy link

This is a bug i have too, it should be a speaker logo not a circle

@plissken1138
Copy link

Same bug here, circle instead of speaker.

@ghnp5
Copy link
Author

ghnp5 commented Oct 15, 2024

Thanks - but just to clarify - besides the circle, I'm also reporting that the button is too big, making it hard to select the pinned tab.

@sakuhanachan
Copy link

found this bug on normal tab too. (on nightly build 133.0a1)

2024-10-17_22-58-45

@adamkkkkkk
Copy link

image

How it normally looks like

image

How it looks like when you hover over it

I also have the same issue of the tab speaker icon being a circle. Firefox Developer Edition v132.0b9 (64-bit) Original Lepton version v8.6.3 Windows 11 Theme System Default.

@ajchow66
Copy link

Confirming the same issue on the latest release Firefox 132.0

@black7375
Copy link
Owner

Thank you for the report.
It will probably be dealt with in the #1011 .

@ghnp5
Copy link
Author

ghnp5 commented Nov 28, 2024

@black7375 - Thanks, but I'm not sure #1011 is the same thing I'm reporting here.

What I'm reporting is that the button is too big on pinned tabs.

I keep accidentally removing the Mute on pinned tabs, because I want to click to open the tab, but instead, I click on the "Unmute" button, so I have to go right click to mute again.

Is it possible to fix this, making the button much smaller?

Thank you!

@black7375
Copy link
Owner

black7375 commented Nov 28, 2024

@ghnp5
It currently consists of 17x17 pixels.

  • 17x17 (Currently)
    image
    image

  • 16x16
    image
    image

  • 15x15
    image
    image

  • 14x14
    image
    image

14x14 certainly seems small.
It looks more appropriate if it's slightly reduced to 16x16. What do you think?

@ghnp5
Copy link
Author

ghnp5 commented Nov 28, 2024

Thank you very much for showing the examples.

I think the problem also is that there is some padding around the icon, which makes the button bigger than it seems while we're not hovering it.
If it's possible to remove the padding (or making it just 1px padding or so), on that 14x14, maybe the icon will be more visible than it is in your screenshot.

What do you think? 14x14, with 1px padding around the icon, so the icon can be a bit bigger.

I just feel that reducing from 17x17 to 16x16 might not really resolve my problem :)

Many thanks!

@ghnp5
Copy link
Author

ghnp5 commented Nov 28, 2024

Also - is it possible to make this change only for pinned tabs?

So the other normal tabs aren't affected.

Not sure if there's some extra parent class or so, to narrow the CSS change...

Thanks!

@black7375
Copy link
Owner

In my opinion, the sizes should be uniform for consistency.
I'll think a little more about the appropriate method.

@black7375 black7375 reopened this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue::Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants