Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #14

Open
kwkroll32 opened this issue Feb 18, 2017 · 1 comment
Open

Refactor #14

kwkroll32 opened this issue Feb 18, 2017 · 1 comment
Assignees

Comments

@kwkroll32
Copy link
Collaborator

The main mucor.py could use a good refactoring. There are a lot of little, specific functions that would be cleaner and more logical as part of the separate class files.

Goals:

  1. move class-specific functions into the respective class files
  2. reduce the number of arguments to (and returned by) these functions
  3. reduce the length and complexity of mucor.py and sub-functions

Bonus:

  1. it would be easier to unit test smaller, self-contained pieces
  2. better suited to take advantage of object oriented programming
@kwkroll32 kwkroll32 self-assigned this Feb 18, 2017
@jblachly
Copy link
Member

jblachly commented Feb 22, 2017

Agree 100% should be refactored.
We need to set some milestones for 2.0.

I recently realized that mucor was responsible for establishing an entirely new category on OmicsTools:
https://omictools.com/variant-aggregation-summarization-category
...and we should carry on in that spirit of innovation.

Please create one enhancement issue per goal, and we can leave this issue open as meta discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants