-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json-CRITICAL #308
Comments
I tried to duplicate your case, run as root, with deteled .config/mainline and with a copy of your config, and in all cases it worked. And yours is dying before it gets to the part where the debug output would have printed some stuff about your system like the distribution. We're almost down to running strace! Can you provide: Also would you mind trying running as a regular user, and starting with no ~/.config/mainline to force it to generate a fresh one. Also, when you say cli, is it a terminal within a desktop session, or is it an ssh login with no desktop or X, no dbus, etc? It's strange that the gui works. That really means there is no problem reading the config file nor a problem with it's exact contents. Does just |
I think I know what's going on, though not why. It's dying on get_string_member, and indeed your config file is missing some recently added fields, including the string fields, auth_cmd and term_cmd. The problem is, it actually should be handling missing members no problem. I actually tried with your config not just with no config, and it read the incomplete file and used the built-in default values for the missing members. Depending on the age of vala and glib-json, there are two different versions of get_string_member that it will use, but they both handle null. Or at least they should. |
Is there more information you need from me? I don't see my previous reply. I'll try again. $ cat /etc/os-release pkg-config json-glib-1.0 Here are the apt show When I run as a regular user it works. Before and after removing ~/.config/mainline. This happens when running with sudo on a terminal session on the desktop or ssh. The help screen displays without error when run as a regular user or with sudo. I am not sure what vala you mean. $ sudo apt show vala* Package: vala-panel-appmenu-common Package: vala-mode-el Package: vala-panel-appmenu Package: vala-0.56-doc Package: vala-panel Package: vala-panel-common Package: vala-panel-plugins-base Package: vala-panel-plugins-wnck Package: vala-sntray-plugin Package: valabind Package: valac-0.56-vapi Package: valac-bin Package: valadoc Package: vala-panel-appmenu-registrar |
Since it works without sudo, and even in sudo it's clearly able to read the file since it can print it back out. And since it works without sudo, it means all necessary packages and libraries are installed and working. I don't know what could be happening in the sudo environment that allows it to read the file with one library function, but apparently not with another library function. The debug output and load_app_config() are using two different functions to read the file. So it's like somehow FileUtils has permission to read the file and Json.Parser does not???? At the same time in the same instance of the same executable??? But those two functions do come from different libraries. Could there be some form of new security thing I never heard of yet that says only libjson-glib-1.0.so.0 doesn't have permission to read the file??? |
does |
There is no difference $ sudo mainline install-latest (process:2821): Json-CRITICAL **: 13:16:30.692: json_object_get_string_member: assertion 'node != NULL' failed (process:2821): Json-CRITICAL **: 13:16:30.692: json_object_get_string_member: assertion 'node != NULL' failed $ sudo -i mainline install-latest (process:2840): Json-CRITICAL **: 13:17:36.844: json_object_get_string_member: assertion 'node != NULL' failed (process:2840): Json-CRITICAL **: 13:17:36.844: json_object_get_string_member: assertion 'node != NULL' failed |
I am getting a Json-CRITICAL error when running from CLI. This prevents updating from the CLI but will update when using the UI.
/usr/bin/mainline install-latest
mainline 1.4.8
(process:7589): Json-CRITICAL **: 09:01:52.161: json_object_get_string_member: assertion 'node != NULL' failed
7589: /usr/bin/mainline install-latest -v 9
7589: load_app_config()
7589: fread(/root/.config/mainline/config.json)
7589: {
"ppa_uri" : "https://kernel.ubuntu.com/~kernel-ppa/mainline/",
"all_proxy" : "",
"connect_timeout_seconds" : 15,
"concurrent_downloads" : 1,
"hide_unstable" : true,
"previous_majors" : 0,
"notify_major" : false,
"notify_minor" : false,
"notify_interval_unit" : 0,
"notify_interval_value" : 4,
"verify_checksums" : false,
"window_width" : 800,
"window_height" : 600,
"window_x" : -1,
"window_y" : -1,
"term_width" : 1100,
"term_height" : 600
}
7589: Loaded config file: /root/.config/mainline/config.json
The text was updated successfully, but these errors were encountered: